path concat #1403
Open
path concat #1403
+254
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
reviewed
Jan 4, 2025
|
|
||
| (* not really non-forgetful, but we can make it local anyway so it's fine*) | ||
| #[local, non_forgetful_inheritance] | ||
| HB.instance Definition _ := isPath.Build ii_i _ _ _ associ |
There was a problem hiding this comment.
I am not sure that this command produces any instance. Its execution returns a one-line response (it used to be invisible in vscode) "HB_unnamed_factory_XY is defined" which usually means failure (I believe that the last version of HB now returns a proper warning).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most technical of all the parts of #1350. This proves that path concatenation has left/right identities, and associates, up to reparameterization. The current proofs are slow, ugly, and ill-named. They are, however, correct.
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers